RESOLVED FIXED 146951
[iOS] Add support for updateSelectionWithExtentPoint:withBoundary 
https://bugs.webkit.org/show_bug.cgi?id=146951
Summary [iOS] Add support for updateSelectionWithExtentPoint:withBoundary
Enrica Casucci
Reported 2015-07-14 17:01:43 PDT
The text selection code on iOS uses this new method that must be supported in WK2. <rdar://problem/20864286> [Orb] One finger Orb text selection not working in WK2
Attachments
Patch (10.50 KB, patch)
2015-07-14 17:10 PDT, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2015-07-14 17:10:29 PDT
Created attachment 256811 [details] Patch
WebKit Commit Bot
Comment 2 2015-07-14 17:13:58 PDT
Attachment 256811 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:933: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:933: The parameter name "point" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:491: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:499: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Enrica Casucci
Comment 3 2015-07-15 10:54:02 PDT
Fixed style issues. Committed revision 186849.
Note You need to log in before you can comment on or make changes to this bug.