Bug 146951 - [iOS] Add support for updateSelectionWithExtentPoint:withBoundary
Summary: [iOS] Add support for updateSelectionWithExtentPoint:withBoundary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-14 17:01 PDT by Enrica Casucci
Modified: 2015-07-15 10:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.50 KB, patch)
2015-07-14 17:10 PDT, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-07-14 17:01:43 PDT 
The text selection code on iOS uses this new method that must be supported in WK2.

<rdar://problem/20864286> [Orb] One finger Orb text selection not working in WK2
Comment 1 Enrica Casucci 2015-07-14 17:10:29 PDT 
Created attachment 256811 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-14 17:13:58 PDT 
Attachment 256811 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:933:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:933:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:491:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:499:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2015-07-15 10:54:02 PDT 
Fixed style issues.
Committed revision 186849.