RESOLVED FIXED146944
Web Inspector: TimelineRuler minimum selection time range should be configurable 
https://bugs.webkit.org/show_bug.cgi?id=146944
Summary Web Inspector: TimelineRuler minimum selection time range should be configurable
Matt Baker
Reported 2015-07-14 15:02:47 PDT
* SUMMARY TimelineRuler minimum selection time range should be configurable. The rendering frames overview uses a non-time horizontal axis, and should specify a minimum selection of one frame.
Attachments
[Patch] Proposed Fix (8.65 KB, patch)
2015-07-14 15:13 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-14 15:03:06 PDT
<rdar://problem/21822720>
Matt Baker
Comment 2 2015-07-14 15:13:18 PDT
Created attachment 256799 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 3 2015-07-14 15:26:42 PDT
Comment on attachment 256799 [details] [Patch] Proposed Fix r=me! Perhaps we should also make it that clicking without any drag selects the frame where you clicked. Right now you have to drag at least a tiny bit for the selection to trigger. But this does feel much better.
Matt Baker
Comment 4 2015-07-14 15:47:00 PDT
(In reply to comment #3) > Comment on attachment 256799 [details] > [Patch] Proposed Fix > > r=me! > > Perhaps we should also make it that clicking without any drag selects the > frame where you clicked. Right now you have to drag at least a tiny bit for > the selection to trigger. But this does feel much better. This is already being done as part of rdar://problem/2122352, when the user clicks a single frame outside the current selection. :)
Matt Baker
Comment 5 2015-07-14 15:47:54 PDT
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 256799 [details] > > [Patch] Proposed Fix > > > > r=me! > > > > Perhaps we should also make it that clicking without any drag selects the > > frame where you clicked. Right now you have to drag at least a tiny bit for > > the selection to trigger. But this does feel much better. > > This is already being done as part of rdar://problem/2122352, when the user > clicks a single frame outside the current selection. :) But we could always break it out as a stand-alone patch.
WebKit Commit Bot
Comment 6 2015-07-14 16:39:15 PDT
Comment on attachment 256799 [details] [Patch] Proposed Fix Clearing flags on attachment: 256799 Committed r186824: <http://trac.webkit.org/changeset/186824>
WebKit Commit Bot
Comment 7 2015-07-14 16:39:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.