Bug 146944 - Web Inspector: TimelineRuler minimum selection time range should be configurable
Summary: Web Inspector: TimelineRuler minimum selection time range should be configurable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-14 15:02 PDT by Matt Baker
Modified: 2015-07-14 16:39 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (8.65 KB, patch)
2015-07-14 15:13 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-07-14 15:02:47 PDT
* SUMMARY
TimelineRuler minimum selection time range should be configurable. The rendering frames overview uses a non-time horizontal axis, and should specify a minimum selection of one frame.
Comment 1 Radar WebKit Bug Importer 2015-07-14 15:03:06 PDT
<rdar://problem/21822720>
Comment 2 Matt Baker 2015-07-14 15:13:18 PDT
Created attachment 256799 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2015-07-14 15:26:42 PDT
Comment on attachment 256799 [details]
[Patch] Proposed Fix

r=me!

Perhaps we should also make it that clicking without any drag selects the frame where you clicked. Right now you have to drag at least a tiny bit for the selection to trigger. But this does feel much better.
Comment 4 Matt Baker 2015-07-14 15:47:00 PDT
(In reply to comment #3)
> Comment on attachment 256799 [details]
> [Patch] Proposed Fix
> 
> r=me!
> 
> Perhaps we should also make it that clicking without any drag selects the
> frame where you clicked. Right now you have to drag at least a tiny bit for
> the selection to trigger. But this does feel much better.

This is already being done as part of rdar://problem/2122352, when the user clicks a single frame outside the current selection. :)
Comment 5 Matt Baker 2015-07-14 15:47:54 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 256799 [details]
> > [Patch] Proposed Fix
> > 
> > r=me!
> > 
> > Perhaps we should also make it that clicking without any drag selects the
> > frame where you clicked. Right now you have to drag at least a tiny bit for
> > the selection to trigger. But this does feel much better.
> 
> This is already being done as part of rdar://problem/2122352, when the user
> clicks a single frame outside the current selection. :)

But we could always break it out as a stand-alone patch.
Comment 6 WebKit Commit Bot 2015-07-14 16:39:15 PDT
Comment on attachment 256799 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256799

Committed r186824: <http://trac.webkit.org/changeset/186824>
Comment 7 WebKit Commit Bot 2015-07-14 16:39:18 PDT
All reviewed patches have been landed.  Closing bug.