WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
146939
Create bindings so that MediaStreamTrackPrivate can be cast to either VideoTrackPrivate or AudioTrackPrivate
https://bugs.webkit.org/show_bug.cgi?id=146939
Summary
Create bindings so that MediaStreamTrackPrivate can be cast to either VideoTr...
Matthew Daiter
Reported
2015-07-14 14:01:14 PDT
Need to do this in order to make sure that the MediaStreamTrackPrivate can be interpreted by the MediaStream Engine
Attachments
Patch
(17.08 KB, patch)
2015-07-15 09:47 PDT
,
Matthew Daiter
no flags
Details
Formatted Diff
Diff
Patch
(17.13 KB, patch)
2015-07-15 09:58 PDT
,
Matthew Daiter
no flags
Details
Formatted Diff
Diff
Patch
(17.54 KB, patch)
2015-07-15 11:35 PDT
,
Matthew Daiter
eric.carlson
: review-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-07-14 14:02:56 PDT
<
rdar://problem/21821125
>
Matthew Daiter
Comment 2
2015-07-15 09:47:23 PDT
Created
attachment 256842
[details]
Patch
Matthew Daiter
Comment 3
2015-07-15 09:58:12 PDT
Created
attachment 256843
[details]
Patch
Matthew Daiter
Comment 4
2015-07-15 11:35:25 PDT
Created
attachment 256847
[details]
Patch
Eric Carlson
Comment 5
2015-07-15 20:16:58 PDT
Comment on
attachment 256847
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=256847&action=review
> Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > +
Please add tests.
> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:197 > + return true;
Only "main" should return true.
> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:203 > + return emptyAtom;
The spec says: AudioTrack.kind and VideoTrack.kind be "main"
> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:241 > + setLanguage(language);
The spec says: AudioTrack.language and VideoTrack.language be the empty string
> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:247 > + // Still haven't dealt with enabling MediaStreamTracks and whether to treat as separate objects inside of HTMLMediaElement yet. > + notImplemented();
The spec says: If a MediaStreamTrack is removed from a MediaStream, played by a media element, the corresponding AudioTrack or VideoTrack must be removed as well.
> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:91 > +
Nit: you don't need this extra blank line
Jon Lee
Comment 6
2016-01-25 14:14:07 PST
This was done elsewhere.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug