Bug 146939 - Create bindings so that MediaStreamTrackPrivate can be cast to either VideoTrackPrivate or AudioTrackPrivate
Summary: Create bindings so that MediaStreamTrackPrivate can be cast to either VideoTr...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Daiter
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 146906
  Show dependency treegraph
 
Reported: 2015-07-14 14:01 PDT by Matthew Daiter
Modified: 2016-01-25 14:14 PST (History)
6 users (show)

See Also:


Attachments
Patch (17.08 KB, patch)
2015-07-15 09:47 PDT, Matthew Daiter
no flags Details | Formatted Diff | Diff
Patch (17.13 KB, patch)
2015-07-15 09:58 PDT, Matthew Daiter
no flags Details | Formatted Diff | Diff
Patch (17.54 KB, patch)
2015-07-15 11:35 PDT, Matthew Daiter
eric.carlson: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Daiter 2015-07-14 14:01:14 PDT
Need to do this in order to make sure that the MediaStreamTrackPrivate can be interpreted by the MediaStream Engine
Comment 1 Radar WebKit Bug Importer 2015-07-14 14:02:56 PDT
<rdar://problem/21821125>
Comment 2 Matthew Daiter 2015-07-15 09:47:23 PDT
Created attachment 256842 [details]
Patch
Comment 3 Matthew Daiter 2015-07-15 09:58:12 PDT
Created attachment 256843 [details]
Patch
Comment 4 Matthew Daiter 2015-07-15 11:35:25 PDT
Created attachment 256847 [details]
Patch
Comment 5 Eric Carlson 2015-07-15 20:16:58 PDT
Comment on attachment 256847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256847&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +

Please add tests.

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:197
> +    return true;

Only "main" should return true.

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:203
> +    return emptyAtom;

The spec says: 

    AudioTrack.kind and VideoTrack.kind be "main"

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:241
> +    setLanguage(language);

The spec says:

    AudioTrack.language and VideoTrack.language be the empty string

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:247
> +    // Still haven't dealt with enabling MediaStreamTracks and whether to treat as separate objects inside of HTMLMediaElement yet.
> +    notImplemented();

The spec says:

    If a MediaStreamTrack is removed from a MediaStream, played by a media element, the corresponding AudioTrack or VideoTrack must be removed as well.

> Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:91
> +

Nit: you don't need this extra blank line
Comment 6 Jon Lee 2016-01-25 14:14:07 PST
This was done elsewhere.