<rdar://problem/19925709>
Created attachment 256791 [details] Patch
Comment on attachment 256791 [details] Patch Attachment 256791 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5734265333481472 New failing tests: svg/W3C-SVG-1.1/animate-elem-02-t.svg
Created attachment 256797 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 256801 [details] Patch
Comment on attachment 256801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review > Source/WebCore/loader/HistoryController.cpp:346 > + // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone. Since a comment is pretty much half the patch, I have to nitpick. // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone.
Committed r186828: <http://trac.webkit.org/changeset/186828>
Comment on attachment 256801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review >> Source/WebCore/loader/HistoryController.cpp:346 >> + // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone. > > Since a comment is pretty much half the patch, I have to nitpick. > > // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone. You got it :)