Bug 146937 - Don't persist history item tree for subframes across reloads.
Summary: Don't persist history item tree for subframes across reloads.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2015-07-14 13:36 PDT by Andreas Kling
Modified: 2015-07-14 19:14 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2015-07-14 13:40 PDT, Andreas Kling
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (603.19 KB, application/zip)
2015-07-14 14:51 PDT, Build Bot
no flags Details
Patch (1.71 KB, patch)
2015-07-14 15:23 PDT, Andreas Kling
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-07-14 13:36:55 PDT
<rdar://problem/19925709>
Comment 1 Andreas Kling 2015-07-14 13:40:34 PDT
Created attachment 256791 [details]
Patch
Comment 2 Build Bot 2015-07-14 14:51:09 PDT
Comment on attachment 256791 [details]
Patch

Attachment 256791 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5734265333481472

New failing tests:
svg/W3C-SVG-1.1/animate-elem-02-t.svg
Comment 3 Build Bot 2015-07-14 14:51:11 PDT
Created attachment 256797 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Andreas Kling 2015-07-14 15:23:29 PDT
Created attachment 256801 [details]
Patch
Comment 5 Brady Eidson 2015-07-14 16:51:58 PDT
Comment on attachment 256801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review

> Source/WebCore/loader/HistoryController.cpp:346
> +        // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone.

Since a comment is pretty much half the patch, I have to nitpick.

// Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone.
Comment 6 Andreas Kling 2015-07-14 19:13:30 PDT
Committed r186828: <http://trac.webkit.org/changeset/186828>
Comment 7 Andreas Kling 2015-07-14 19:14:32 PDT
Comment on attachment 256801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review

>> Source/WebCore/loader/HistoryController.cpp:346
>> +        // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone.
> 
> Since a comment is pretty much half the patch, I have to nitpick.
> 
> // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone.

You got it :)
Comment 8 Andreas Kling 2015-07-14 19:14:33 PDT
Comment on attachment 256801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256801&action=review

>> Source/WebCore/loader/HistoryController.cpp:346
>> +        // Just rebuild the history item tree when reloading, since trying to re-associate everything would be too error-prone.
> 
> Since a comment is pretty much half the patch, I have to nitpick.
> 
> // Rebuild the history item tree when reloading as trying to re-associate everything is too error-prone.

You got it :)