Bug 146921 – [CoordinatedGraphics] Remove setContentsScale from TiledBackingStore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

setContentsScale is only used to create TiledBackingStore.

[Ryuan Choi]

Created attachment 256741 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 256741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256741&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:-124
> -    m_tiles.clear();

If there is no problem when we don't call below two functions, LGTM.

  m_tiles.clear();
  coverWithTilesIfNeeded();

[Ryuan Choi]

Created attachment 256752 [details]
Patch

[Ryuan Choi]

(In reply to comment #2)
> Comment on attachment 256741 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256741&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:-124
> > -    m_tiles.clear();
> 
> If there is no problem when we don't call below two functions, LGTM.
> 
>   m_tiles.clear();

We don't need to clear tiles because TiledBackingStore didn't make them.

>   coverWithTilesIfNeeded();

I missed to cover it. I updated the patch. thanks.

[Gyuyoung Kim]

Comment on attachment 256752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256752&action=review

To be honest, I don't know what is benefit when we drop setContentsScale().

> Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h:41
> +    TiledBackingStore(TiledBackingStoreClient*, float contentsScale);

It would be nice if we set default value.

TiledBackingStore(TiledBackingStoreClient*, float contentsScale = 1.f)

[Ryuan Choi]

Comment on attachment 256752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256752&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h:41
>> +    TiledBackingStore(TiledBackingStoreClient*, float contentsScale);
> 
> It would be nice if we set default value.
> 
> TiledBackingStore(TiledBackingStoreClient*, float contentsScale = 1.f)

Hmm, are there any reason?
We alwasys create TiledBackingStore with two arguments.

[Gyuyoung Kim]

Comment on attachment 256752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256752&action=review

>>> Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.h:41
>>> +    TiledBackingStore(TiledBackingStoreClient*, float contentsScale);
>> 
>> It would be nice if we set default value.
>> 
>> TiledBackingStore(TiledBackingStoreClient*, float contentsScale = 1.f)
> 
> Hmm, are there any reason?
> We alwasys create TiledBackingStore with two arguments.

Because we have initialized the contentsScale with 1.f. 

, m_contentsScale(1.f)

I think it would be good if we keep it in constructor as well. If so, we can use a argument when we don't need to set other scale value.

[Ryuan Choi]

Created attachment 256763 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 256763 [details]
Patch

rs=me.

[WebKit Commit Bot]

Comment on attachment 256763 [details]
Patch

Clearing flags on attachment: 256763

Committed r186884: <http://trac.webkit.org/changeset/186884>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.