Bug 146897 - If Watchpoint::fire() looks at the state of the world, it should definitely see its set invalidated, and maybe it should see the object of interest in the transitioned-to state
Summary: If Watchpoint::fire() looks at the state of the world, it should definitely s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-12 21:43 PDT by Filip Pizlo
Modified: 2015-07-13 13:11 PDT (History)
12 users (show)

See Also:

Attachments
the patch (13.42 KB, patch)
2015-07-12 21:51 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (13.69 KB, patch)
2015-07-12 21:54 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-12 21:43:19 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-07-12 21:51:21 PDT 
Created attachment 256685 [details]
the patch
Comment 2 Filip Pizlo 2015-07-12 21:54:44 PDT 
Created attachment 256686 [details]
the patch

moar changelog.
Comment 3 Mark Lam 2015-07-13 08:41:56 PDT 
Comment on attachment 256686 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256686&action=review

r=me

> Source/JavaScriptCore/ChangeLog:34
> +        it would fine that the singleton object's structure is no longer watchable. This is

typo: fine => find.
Comment 4 Filip Pizlo 2015-07-13 13:11:25 PDT 
Landed in http://trac.webkit.org/changeset/186776