REGRESSION (r177876): store.apple.com profile and cart icons are missing

[Antti Koivisto]

Two competing @font-face rules with only one having the correct glyphs.

[Antti Koivisto]

rdar://problem/21736723

[Antti Koivisto]

Created attachment 256683 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 256683 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256683&action=review

> LayoutTests/fast/css/font-face-multiple-missing-glyphs-expected.html:7
> +    font-family:AppleIcons;

Is this available under an appropriate license?

[Antti Koivisto]

> Is this available under an appropriate license?

No idea.

[Myles C. Maxfield]

Comment on attachment 256683 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256683&action=review

r=me

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:339
> +        ++fallbackIndex;

I don't understand. It doesn't look like there is a "continue" anywhere in the loop which will cause this to be skipped. Why did you move this to the bottom of the loop?

>> LayoutTests/fast/css/font-face-multiple-missing-glyphs-expected.html:7
>> +    font-family:AppleIcons;
> 
> Is this available under an appropriate license?

You can author your own font in SVG for this test. Should be straightforward.

[Myles C. Maxfield]

Committed r186809: <http://trac.webkit.org/changeset/186809>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 146943

[Mark Lam]

Rolled out in http://trac.webkit.org/changeset/186816.

[Antti Koivisto]

Thanks for updating the test case but you probably didn't want to include the SimpleLineLayout.cpp change.

[Myles C. Maxfield]

(In reply to comment #9)
> Thanks for updating the test case but you probably didn't want to include
> the SimpleLineLayout.cpp change.

hahah .... whoops. :(

[Myles C. Maxfield]

Committed r186827: <http://trac.webkit.org/changeset/186827>