Bug 146892 - [GTK] ENABLE_TOUCH_EVENTS=OFF allowed but then it can't compile
Summary: [GTK] ENABLE_TOUCH_EVENTS=OFF allowed but then it can't compile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-12 02:52 PDT by nick
Modified: 2018-01-25 07:38 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nick 2015-07-12 02:52:59 PDT 
when i am trying to build gtk port cmake allow generating makefile in case of -DENABLE_TOUCH_EVENTS=OFF

But gtk unconditionally presume as it is enabled. So in compilation stage i get:

In file included from /home/me/src/webkitgtk-2.9.3/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:75:0:
/home/me/src/webkitgtk-2.9.3/Source/WebKit2/Shared/gtk/WebEventFactory.h:42:12: error: ‘WebTouchEvent’ does not name a type
     static WebTouchEvent createWebTouchEvent(const GdkEvent*, Vector<WebPlatformTouchPoint>&&);

webkitgtk-2.9.3
Comment 1 nick 2015-07-12 02:59:29 PDT 
And similar errors for other touch related classes.
Comment 2 Claudio Saavedra 2018-01-25 07:38:28 PST 
This doesn't seem to be failing anymore in the way it's described here, although there were a couple of build errors in unrelated sources that were not including the GTK+ header file and were indirectly getting it from a touch events header. I fixed those in https://trac.webkit.org/changeset/227606.