SSIA. editing/selection/5354455-1.html [ Failure ] editing/selection/5354455-2.html [ Failure ] editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ] editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ] editing/spelling/context-menu-suggestions.html [ Failure ]
This was probably due to my change here: @@ -474,9 +476,5 @@ JSContextRef context = WKBundleFrameGetJavaScriptContext(mainFrame); #if ENABLE(CONTEXT_MENUS) - // Do mouse context click. - mouseDown(2, 0); - mouseUp(2, 0); - - WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuItems(page)); + WKRetainPtr<WKArrayRef> menuEntries = adoptWK(WKBundlePageCopyContextMenuAtPointInWindow(page, m_position)); JSValueRef arrayResult = JSObjectMakeArray(context, 0, 0, 0); JSObjectRef arrayObj = JSValueToObject(context, arrayResult, 0); On Mac, the context menu is modal, so no further WebKit activity happens until the dialog is dismissed. So we can't use the mouseDown/mouseUp combination here -- it just blocks the test from running. Maybe you could just #if/def my change so thet it works like it used to on EFL and uses my revised code for Mac/Windows, and perhaps Gtk.
Created attachment 258173 [details] Patch
Could I restore the codes?
Created attachment 258174 [details] Patch
Created attachment 258175 [details] Patch
Comment on attachment 258175 [details] Patch Looks fine to me.
Comment on attachment 258175 [details] Patch Clearing flags on attachment: 258175 Committed r187934: <http://trac.webkit.org/changeset/187934>
All reviewed patches have been landed. Closing bug.