Bug 146883 - Allow clients to opt-out of default app link link actions
Summary: Allow clients to opt-out of default app link link actions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-11 15:11 PDT by Joseph Pecoraro
Modified: 2015-07-11 16:00 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (16.80 KB, patch)
2015-07-11 15:29 PDT, Joseph Pecoraro 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-11 15:11:30 PDT 
* SUMMARY
Some clients may not want WebKit to create AppLink link actions, allow clients to opt out via a delegate.
Comment 1 Joseph Pecoraro 2015-07-11 15:16:30 PDT 
Another part of: <rdar://problem/21221902>
Comment 2 Joseph Pecoraro 2015-07-11 15:29:17 PDT 
Created attachment 256669 [details]
[PATCH] Proposed Fix

Bots may not build this as it relies on an earlier change that hasn't landed yet.
Comment 3 mitz 2015-07-11 15:34:31 PDT 
Comment on attachment 256669 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=256669&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:58
> +- (BOOL)_webView:(WKWebView *)webView shouldIncludeAppLinkActionsForElement:(_WKActivatedElementInfo *)element;

We’ve decided to specify availability for delegate methods, and to do so for SPI as well as API, so please add WK_AVAILABLE(NA, WK_IOS_TBA) here.
Comment 4 Joseph Pecoraro 2015-07-11 16:00:53 PDT 
http://trac.webkit.org/changeset/186719