Bug 146882 - Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements
Summary: Web Inspector: Type profiler shows 'Undefined' annotation for functions with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-11 14:50 PDT by Saam Barati
Modified: 2015-08-21 20:27 PDT (History)
9 users (show)

See Also:


Attachments
patch (3.34 KB, patch)
2015-08-21 17:36 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-07-11 14:50:05 PDT
Even though JS implicitly returns undefined, we decided not to show
return types unless there is an explicit 'return <expr>' in the function. 
I'm not sure how this got reverted but I will fix it.
Comment 1 Radar WebKit Bug Importer 2015-07-11 14:50:18 PDT
<rdar://problem/21783141>
Comment 2 Saam Barati 2015-08-21 17:36:58 PDT
Created attachment 259688 [details]
patch
Comment 3 Joseph Pecoraro 2015-08-21 19:40:33 PDT
Comment on attachment 259688 [details]
patch

r=me, Though I wonder if we could write a test for this.
Comment 4 WebKit Commit Bot 2015-08-21 20:27:34 PDT
Comment on attachment 259688 [details]
patch

Clearing flags on attachment: 259688

Committed r188818: <http://trac.webkit.org/changeset/188818>
Comment 5 WebKit Commit Bot 2015-08-21 20:27:38 PDT
All reviewed patches have been landed.  Closing bug.