Bug 146881 – Get rid of the implicit NSGeometry type conversions

• Status: NEW
• Component: New Bugs

[Anders Carlsson]

Get rid of the implicit NSGeometry type conversions

[Anders Carlsson]

Created attachment 256665 [details]
Patch

[WebKit Commit Bot]

Attachment 256665 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/mac/AlternativeTextUIController.mm:96:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/CorrectionPanel.mm:88:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:713:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Created attachment 256668 [details]
Patch

[WebKit Commit Bot]

Attachment 256668 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/mac/AlternativeTextUIController.mm:96:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/CorrectionPanel.mm:88:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebFrame.mm:713:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Misc/WebIconDatabase.mm:141:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm:80:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 6 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 256668 [details]
Patch

Attachment 256668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5098151149043712

New failing tests:
fast/replaced/object-with-embed-url-param.html

[Build Bot]

Created attachment 256670 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Brent Fulgham]

Comment on attachment 256668 [details]
Patch

Do we still want this patch? It seems like it may have bit rotten in the last six months. :-\

[Brady Eidson]

Comment on attachment 256668 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.