Bug 146875 - DFG::DesiredWatchpoints should accept WatchpointSetType's that aren't necessarily pointers
Summary: DFG::DesiredWatchpoints should accept WatchpointSetType's that aren't necessa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-10 23:05 PDT by Filip Pizlo
Modified: 2015-07-10 23:42 PDT (History)
13 users (show)

See Also:

Attachments
the patch (4.96 KB, patch)
2015-07-10 23:08 PDT, Filip Pizlo 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-10 23:05:54 PDT 
In the future we'll want to add a desired watchpoint set that's something like "please watch property 'Foo' for 'deletion' on structure 'S1'", so that the "set type" is struct like "struct MySet { StringImpl* property; Mode mode; Structure* structure };".
Comment 1 Filip Pizlo 2015-07-10 23:08:22 PDT 
Created attachment 256646 [details]
the patch
Comment 2 Filip Pizlo 2015-07-10 23:42:54 PDT 
Landed in http://trac.webkit.org/changeset/186706