Diagnostic logging messages are causing too much IPC.
Created attachment 256644 [details]
Comment on attachment 256644 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=256644&action=review
> + static bool shouldLogGivenSampling(ShouldSample);
I'm not certain if this is the most descriptive name. How about isLogSelectedInSample or shouldLogAfterSampling?
> + // Log 5% of messages when sampling.
I don't think we need this comment. The code speaks for itself.
> + parentProcessConnection()->send(Messages::NetworkProcessProxy::LogPreSampledDiagnosticMessage(webPageID, message, description), 0);
I don't think it makes sense to call these PreSampled. If anything, these are post sampling.
Why don't we simply call it LogSampledDiagnosticMessage?
Created attachment 256649 [details]
Comment on attachment 256649 [details]
Clearing flags on attachment: 256649
Committed r186707: <http://trac.webkit.org/changeset/186707>
All reviewed patches have been landed. Closing bug.