Bug 146873 – [WK2] Diagnostic logging messages are causing too much IPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Diagnostic logging messages are causing too much IPC.

[Chris Dumez]

rdar://problem/21779205

[Chris Dumez]

Created attachment 256644 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 256644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256644&action=review

> Source/WebCore/page/DiagnosticLoggingClient.h:45
> +    static bool shouldLogGivenSampling(ShouldSample);

I'm not certain if this is the most descriptive name.  How about isLogSelectedInSample or shouldLogAfterSampling?

> Source/WebCore/page/DiagnosticLoggingClient.h:56
> +    // Log 5% of messages when sampling.

I don't think we need this comment.  The code speaks for itself.

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:485
> +    parentProcessConnection()->send(Messages::NetworkProcessProxy::LogPreSampledDiagnosticMessage(webPageID, message, description), 0);

I don't think it makes sense to call these PreSampled.  If anything, these are post sampling.
Why don't we simply call it LogSampledDiagnosticMessage?

[Chris Dumez]

Created attachment 256649 [details]
Patch

[Chris Dumez]

Comment on attachment 256649 [details]
Patch

Clearing flags on attachment: 256649

Committed r186707: <http://trac.webkit.org/changeset/186707>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.