Bug 146863 - Remove incorrect overriding of inputAssistantItem in WKContentView
Summary: Remove incorrect overriding of inputAssistantItem in WKContentView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-10 18:01 PDT by Enrica Casucci
Modified: 2015-07-11 14:32 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2015-07-10 18:05 PDT, Enrica Casucci
mitz: review+
Details | Formatted Diff | Diff
Patch2 (2.09 KB, patch)
2015-07-11 13:56 PDT, Enrica Casucci
sam: review+
Details | Formatted Diff | Diff
Patch3 (2.15 KB, patch)
2015-07-11 14:28 PDT, Enrica Casucci
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-07-10 18:01:40 PDT
The keyboard is entirely responsible for this and WebKit should not override it.

rdar://problem/21507154
Comment 1 Enrica Casucci 2015-07-10 18:05:52 PDT
Created attachment 256631 [details]
Patch
Comment 2 mitz 2015-07-10 18:13:04 PDT
Comment on attachment 256631 [details]
Patch

r=me assuming you tested this change in isolation (without related UIKit changes).
Comment 3 Enrica Casucci 2015-07-11 11:59:35 PDT
(In reply to comment #2)
> Comment on attachment 256631 [details]
> Patch
> 
> r=me assuming you tested this change in isolation (without related UIKit
> changes).

I did. In fact the WebKit changes but itself is enough to fixe the bug. The UIKit changes are for cleanup and to fix WK1.
Thank you!
Comment 4 Enrica Casucci 2015-07-11 12:03:44 PDT
Committed revision 186713.
Comment 5 Enrica Casucci 2015-07-11 13:41:59 PDT
Found a bug in the previous patch. Reopening.
Comment 6 Enrica Casucci 2015-07-11 13:56:06 PDT
Created attachment 256664 [details]
Patch2
Comment 7 Enrica Casucci 2015-07-11 14:28:50 PDT
Created attachment 256666 [details]
Patch3

Fix the iOS EWS.
Comment 8 Enrica Casucci 2015-07-11 14:32:10 PDT
Committed revision 186716.