Bug 146853 – Add HTMLMediaElement behavior and attribute value restrictions for MediaStream

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Matthew Daiter]

HTMLMediaElement has necessary conditions when running a MediaStream. These conditions must be met to run with standard behavior.

[Radar WebKit Bug Importer]

<rdar://problem/21772688>

[Eric Carlson]

Created attachment 264601 [details]
Proposed patch.

[Jer Noble]

Comment on attachment 264601 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=264601&action=review

r=me, with the most minor of nits. (Don't feel like you have to change the patch though.)

> Source/WebCore/Modules/mediastream/MediaStream.cpp:287
> +    bool active = false;
> +    for (auto& track : m_trackSet.values()) {
> +        if (!track->ended()) {
> +            active = true;
> +            break;
> +        }
> +    }

It's not really worth it, but you could do:

auto& tracks = m_trackSet.values();
bool active = std::any_of(tracks.begin(), tracks.end(), [] (Track* track) { return !track->ended(); });

I wish we had those STL algorithms directly on our storage classes so we could do `m_trackSet.values().any_of([](auto track) { return !track->ended(); });`

[WebKit Commit Bot]

Comment on attachment 264601 [details]
Proposed patch.

Clearing flags on attachment: 264601

Committed r191909: <http://trac.webkit.org/changeset/191909>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.