Bug 146850 - jsc-tailcall: Implement the tail call opcodes in the DFG
Summary: jsc-tailcall: Implement the tail call opcodes in the DFG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
: 147198 (view as bug list)
Depends on: 146484
Blocks: 146477 146851 147198
  Show dependency tree / graph
 
Reported: 2015-07-10 12:38 PDT by Basile Clement
Modified: 2015-08-04 10:50 PDT (History)
7 users (show)

See Also:

Attachments
Patch (83.04 KB, patch)
2015-07-31 19:08 PDT, Basile Clement 		no flags Details | Formatted Diff | Diff
Patch (83.06 KB, patch)
2015-08-03 14:42 PDT, Basile Clement 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-07-10 12:38:57 PDT 
...
Comment 1 Basile Clement 2015-07-31 14:49:36 PDT 
*** Bug 147198 has been marked as a duplicate of this bug. ***
Comment 2 Basile Clement 2015-07-31 19:08:34 PDT 
Created attachment 257988 [details]
Patch
Comment 3 Basile Clement 2015-07-31 19:40:31 PDT 
Just realized this is missing callee save stuff.
Comment 4 Basile Clement 2015-08-03 14:42:45 PDT 
Created attachment 258116 [details]
Patch
Comment 5 Michael Saboff 2015-08-03 16:02:56 PDT 
Comment on attachment 258116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258116&action=review

r+me with a couple of comments.

> Source/JavaScriptCore/ChangeLog:13
> +         - EmulatedTailCall and EmulatedTailCallVarargs are here to perform a

What about changing Emulated* to Inlined*?

> Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:139
> +    // FIXME: We shouldn't leave holes on the stack when performing an OSR exit

Please add a bug for the FIXME

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:881
> +        m_jit.breakpoint();

This should only be for debug builds.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:842
> +        m_jit.breakpoint();

Ditto
Comment 6 Basile Clement 2015-08-03 16:17:58 PDT 
(In reply to comment #5)
> Comment on attachment 258116 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258116&action=review
> 
> r+me with a couple of comments.
> 
> > Source/JavaScriptCore/ChangeLog:13
> > +         - EmulatedTailCall and EmulatedTailCallVarargs are here to perform a
> 
> What about changing Emulated* to Inlined*?

I find InlinedTailCall to be confusing since the tail call itself is not inlined, it is inside an inlined function. And TailCallInsideAnInlinedFunction is not great either. But I'm open to suggestions.
 
> > Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:139
> > +    // FIXME: We shouldn't leave holes on the stack when performing an OSR exit
> 
> Please add a bug for the FIXME

Oops, thought I did that already. I'll add it.
Comment 7 Michael Saboff 2015-08-03 16:37:42 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Comment on attachment 258116 [details]
> > > Source/JavaScriptCore/ChangeLog:13
> > > +         - EmulatedTailCall and EmulatedTailCallVarargs are here to perform a
> > 
> > What about changing Emulated* to Inlined*?
> 
> I find InlinedTailCall to be confusing since the tail call itself is not
> inlined, it is inside an inlined function. And
> TailCallInsideAnInlinedFunction is not great either. But I'm open to
> suggestions.

What about TailCallInlinedCaller?
Comment 8 Basile Clement 2015-08-04 10:50:52 PDT 
Committed r187791 <https://trac.webkit.org/changeset/187791>.