Bug 146847 – jsc-tailcall: Get rid of the arity fixup return thunk

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Basile Clement]

We need to get rid of this for implementing tail calls since after a tail call, the stack is no longer going to be in a meaningful state for the arity fixup return thunk.

[Basile Clement]

Created attachment 256729 [details]
Patch

[Michael Saboff]

Comment on attachment 256729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256729&action=review

r=me after splitting the patch in two.

> Source/JavaScriptCore/runtime/Options.h:159
> -    v(bool, useFTLJIT, true, "allows the FTL JIT to be used if true") \
> +    v(bool, useFTLJIT, false, "allows the FTL JIT to be used if true") \

Break this out into a separate bug and patch.

[Basile Clement]

(In reply to comment #2)
> Comment on attachment 256729 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256729&action=review
> 
> r=me after splitting the patch in two.
> 
> > Source/JavaScriptCore/runtime/Options.h:159
> > -    v(bool, useFTLJIT, true, "allows the FTL JIT to be used if true") \
> > +    v(bool, useFTLJIT, false, "allows the FTL JIT to be used if true") \
> 
> Break this out into a separate bug and patch.

Makes sense, created https://bugs.webkit.org/show_bug.cgi?id=146941 for this and https://bugs.webkit.org/show_bug.cgi?id=146942 to re-enable the FTL.

[Basile Clement]

Committed in r186820 <http://trac.webkit.org/changeset/186820>.

[Csaba Osztrogonác]

Comment on attachment 256729 [details]
Patch

Cleared review? from attachment 256729 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).