Bug 146847 - jsc-tailcall: Get rid of the arity fixup return thunk
Summary: jsc-tailcall: Get rid of the arity fixup return thunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
Depends on: 146846 146941
Blocks: 146484
  Show dependency tree / graph
 
Reported: 2015-07-10 12:28 PDT by Basile Clement
Modified: 2015-09-14 10:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (28.35 KB, patch)
2015-07-13 14:36 PDT, Basile Clement 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-07-10 12:28:04 PDT 
We need to get rid of this for implementing tail calls since after a tail call, the stack is no longer going to be in a meaningful state for the arity fixup return thunk.
Comment 1 Basile Clement 2015-07-13 14:36:23 PDT 
Created attachment 256729 [details]
Patch
Comment 2 Michael Saboff 2015-07-14 14:08:48 PDT 
Comment on attachment 256729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256729&action=review

r=me after splitting the patch in two.

> Source/JavaScriptCore/runtime/Options.h:159
> -    v(bool, useFTLJIT, true, "allows the FTL JIT to be used if true") \
> +    v(bool, useFTLJIT, false, "allows the FTL JIT to be used if true") \

Break this out into a separate bug and patch.
Comment 3 Basile Clement 2015-07-14 14:15:53 PDT 
(In reply to comment #2)
> Comment on attachment 256729 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256729&action=review
> 
> r=me after splitting the patch in two.
> 
> > Source/JavaScriptCore/runtime/Options.h:159
> > -    v(bool, useFTLJIT, true, "allows the FTL JIT to be used if true") \
> > +    v(bool, useFTLJIT, false, "allows the FTL JIT to be used if true") \
> 
> Break this out into a separate bug and patch.

Makes sense, created https://bugs.webkit.org/show_bug.cgi?id=146941 for this and https://bugs.webkit.org/show_bug.cgi?id=146942 to re-enable the FTL.
Comment 4 Basile Clement 2015-07-14 15:08:36 PDT 
Committed in r186820 <http://trac.webkit.org/changeset/186820>.
Comment 5 Csaba Osztrogonác 2015-09-14 10:56:51 PDT 
Comment on attachment 256729 [details]
Patch

Cleared review? from attachment 256729 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).