Bug 146843 - Crash at WebCore::WebPage::innerFrameQuad.
Summary: Crash at WebCore::WebPage::innerFrameQuad.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-10 11:18 PDT by zalan
Modified: 2015-07-10 13:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.68 KB, patch)
2015-07-10 11:28 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2015-07-10 12:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-07-10 11:18:11 PDT 
Crash at WebCore::WebPage::innerFrameQuad
Comment 1 zalan 2015-07-10 11:18:45 PDT 
rdar://problem/21501819
Comment 2 zalan 2015-07-10 11:28:56 PDT 
Created attachment 256595 [details]
Patch
Comment 3 Andreas Kling 2015-07-10 11:36:36 PDT 
Comment on attachment 256595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256595&action=review

r=me

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:782
> +    RenderObject* renderer = nullptr;

This should be a RenderElement*.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:786
> +    else if (assistedNode.rootEditableElement())
> +        renderer = assistedNode.rootEditableElement()->renderer();

Can we avoid computing rootEditableElement() twice here?
Comment 4 zalan 2015-07-10 12:24:31 PDT 
Created attachment 256601 [details]
Patch
Comment 5 WebKit Commit Bot 2015-07-10 13:20:59 PDT 
Comment on attachment 256601 [details]
Patch

Clearing flags on attachment: 256601

Committed r186684: <http://trac.webkit.org/changeset/186684>
Comment 6 WebKit Commit Bot 2015-07-10 13:21:03 PDT 
All reviewed patches have been landed.  Closing bug.