RESOLVED WONTFIX 146841
[WK2][iOS] Fix build with !ENABLE(NETWORK_PROCESS) 
https://bugs.webkit.org/show_bug.cgi?id=146841
Summary [WK2][iOS] Fix build with !ENABLE(NETWORK_PROCESS)
Chris Dumez
Reported 2015-07-10 10:53:44 PDT
Fix build with !ENABLE(NETWORK_PROCESS).
Attachments
Patch (15.35 KB, patch)
2015-07-10 11:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-07-10 11:01:46 PDT
Why do we need this working at all?
Chris Dumez
Comment 2 2015-07-10 11:04:43 PDT
(In reply to comment #1) > Why do we need this working at all? Maintaining this configuration is useful for testing purposes. For e.g., we are currently investigating a possible IPC perf regression.
Chris Dumez
Comment 3 2015-07-10 11:19:24 PDT
Created attachment 256594 [details] Patch
Anders Carlsson
Comment 4 2015-07-10 11:34:19 PDT
(In reply to comment #2) > (In reply to comment #1) > > Why do we need this working at all? > > Maintaining this configuration is useful for testing purposes. For e.g., we > are currently investigating a possible IPC perf regression. From what? From enabling the Network Process? The non-network process configuration has never shipped on iOS.
Chris Dumez
Comment 5 2015-07-10 12:14:12 PDT
Hmm, there is a WebProcessPool::setUsesNetworkProcess() to do this at run time. At the moment, this is only exposed via a private C API but I guess this is enough for testing.
Alexey Proskuryakov
Comment 6 2015-07-10 23:14:25 PDT
It is likely that disabling NetworkProcess at runtime will change too much for being a useful testing tool. We won't use WebKit persistent cache, and I believe that CFNetwork cache is already broken on iOS due to some path/sandboxing confusion.
Note You need to log in before you can comment on or make changes to this bug.