Bug 146841 - [WK2][iOS] Fix build with !ENABLE(NETWORK_PROCESS)
Summary: [WK2][iOS] Fix build with !ENABLE(NETWORK_PROCESS)
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-10 10:53 PDT by Chris Dumez
Modified: 2015-07-10 23:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (15.35 KB, patch)
2015-07-10 11:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-07-10 10:53:44 PDT 
Fix build with !ENABLE(NETWORK_PROCESS).
Comment 1 Anders Carlsson 2015-07-10 11:01:46 PDT 
Why do we need this working at all?
Comment 2 Chris Dumez 2015-07-10 11:04:43 PDT 
(In reply to comment #1)
> Why do we need this working at all?

Maintaining this configuration is useful for testing purposes. For e.g., we are currently investigating a possible IPC perf regression.
Comment 3 Chris Dumez 2015-07-10 11:19:24 PDT 
Created attachment 256594 [details]
Patch
Comment 4 Anders Carlsson 2015-07-10 11:34:19 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Why do we need this working at all?
> 
> Maintaining this configuration is useful for testing purposes. For e.g., we
> are currently investigating a possible IPC perf regression.

From what? From enabling the Network Process? The non-network process configuration has never shipped on iOS.
Comment 5 Chris Dumez 2015-07-10 12:14:12 PDT 
Hmm, there is a WebProcessPool::setUsesNetworkProcess() to do this at run time. At the moment, this is only exposed via a private C API but I guess this is enough for testing.
Comment 6 Alexey Proskuryakov 2015-07-10 23:14:25 PDT 
It is likely that disabling NetworkProcess at runtime will change too much for being a useful testing tool. We won't use WebKit persistent cache, and I believe that CFNetwork cache is already broken on iOS due to some path/sandboxing confusion.