Change load(MediaStreamPrivate*) method to use references

[Matthew Daiter]

MediaPlayerPrivateInterface derivatives should be able to load MediaStreamPrivate methods without worrying about whether the MediaStreamPrivate is null or not.

[Radar WebKit Bug Importer]

<rdar://problem/21769035>

[Matthew Daiter]

Created attachment 256592 [details]
Patch

[Matthew Daiter]

Created attachment 256607 [details]
Patch

[Darin Adler]

Comment on attachment 256607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256607&action=review

So no one uses this argument yet?

> Source/WebCore/platform/graphics/MediaPlayer.cpp:427
> +            m_private->load(*m_mediaStream.get());

Should not need .get() here.

> Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h:64
> +    virtual void load(MediaStreamPrivate&) override { };

Should remove the stray semicolon here.

[Matthew Daiter]

Created attachment 256626 [details]
Patch

[Brent Fulgham]

*** Bug 146811 has been marked as a duplicate of this bug. ***

[Brent Fulgham]

Turning off cq+, because Matthew hasn't addressed Darin's comments.

[Brent Fulgham]

(In reply to comment #4)
> Comment on attachment 256607 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256607&action=review
> 
> So no one uses this argument yet?
> 
> > Source/WebCore/platform/graphics/MediaPlayer.cpp:427
> > +            m_private->load(*m_mediaStream.get());
> 
> Should not need .get() here.

I'll fix while landing.

> > Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h:64
> > +    virtual void load(MediaStreamPrivate&) override { };
> 
> Should remove the stray semicolon here.

Ditto.

[Brent Fulgham]

Committed r186769: <http://trac.webkit.org/changeset/186769>