Bug 146829 – Enable STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE for GCC

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/155143 disabled STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE
on GCC builds due to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52702 .

But this bug is already solved long time ago, we already relies on newer GCC.

[Csaba Osztrogonác]

Created attachment 256572 [details]
Patch

[Darin Adler]

Comment on attachment 256572 [details]
Patch

What port is building with non-clang gcc? I’m not sure we should do the work to support that any more unless there is real benefit.

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 256572 [details]
> Patch
> 
> What port is building with non-clang gcc? I’m not sure we should do the work
> to support that any more unless there is real benefit.

EFL and GTK.

[Anders Carlsson]

Comment on attachment 256572 [details]
Patch

I think a better solution would be to just reimplement std::is_trivially_destructible in terms of std::has_trivial_destructor for MSVC and get rid of the compiler checks altogether.

[Csaba Osztrogonác]

Created attachment 257273 [details]
Patch

Additionally removed the MSVC workaround since MSVC 2012 already supports std::is_trivially_destructible.

[Csaba Osztrogonác]

(In reply to comment #5)
> Created attachment 257273 [details]
> Patch
> 
> Additionally removed the MSVC workaround since MSVC 2012 already supports
> std::is_trivially_destructible.

And now MSVC 2013 is mandatory - https://lists.webkit.org/pipermail/webkit-dev/2013-December/025941.html

[Brent Fulgham]

Comment on attachment 257273 [details]
Patch

This looks good! Thanks.

[WebKit Commit Bot]

Comment on attachment 257273 [details]
Patch

Clearing flags on attachment: 257273

Committed r187167: <http://trac.webkit.org/changeset/187167>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.