Bug 146827 – [GTK] Accelerated compositing is enabled by MiniBrowser in Wayland

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

SSIA

[ChangSeok Oh]

Created attachment 256569 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 256569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256569&action=review

> Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:46
> +#if PLATFORM(WAYLAND)
> +    // FIXME: Accelerated compositing under Wayland is not yet supported.
> +    // https://bugs.webkit.org/show_bug.cgi?id=115803
> +    GdkDisplay* display = gdk_display_manager_get_default_display(gdk_display_manager_get());
> +    if (GDK_IS_WAYLAND_DISPLAY(display))
> +        setAcceleratedCompositingEnabled(false);
> +#endif

I think this could be simplified using PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland. So, can we move this here instead of duplicating it? or do we really need it in both places?

[ChangSeok Oh]

Created attachment 256691 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[ChangSeok Oh]

Comment on attachment 256569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256569&action=review

>> Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:46
>> +#endif
> 
> I think this could be simplified using PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland. So, can we move this here instead of duplicating it? or do we really need it in both places?

Oh. You're right. I saw this bug in webkitgtk.2.8.3 so I didn't know the PlatformDisplay. I think moving the disabling code here is enough. =)

[ChangSeok Oh]

Created attachment 256692 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256692 [details]
Patch

Clearing flags on attachment: 256692

Committed r186835: <http://trac.webkit.org/changeset/186835>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.