Bug 146826 - [CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer
Summary: [CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-10 00:27 PDT by Ryuan Choi
Modified: 2015-07-10 17:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2015-07-10 02:23 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-07-10 00:27:09 PDT 
primaryLayerID is usefull to debug layer tree using showGraphicsLayerTree()
Comment 1 Ryuan Choi 2015-07-10 02:23:06 PDT 
Created attachment 256570 [details]
Patch
Comment 2 Gyuyoung Kim 2015-07-10 03:07:14 PDT 
Comment on attachment 256570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256570&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124
> +    CoordinatedLayerID id() const { return m_id; }

primaryLayerID() just returns id(). So I'm not 100% sure if we should continue to keep id(). r+ed for now.
Comment 3 Ryuan Choi 2015-07-10 06:23:18 PDT 
(In reply to comment #2)
> Comment on attachment 256570 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256570&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124
> > +    CoordinatedLayerID id() const { return m_id; }
> 
> primaryLayerID() just returns id(). So I'm not 100% sure if we should
> continue to keep id(). r+ed for now.

While PlatformLayerID is uint64_t, CoordinatedGraphicsLayer uses uint32_t as id and id is widely used including IPC message.

If refactoring does not have critical performance regression, we can remove id.
I will check it.
Comment 4 WebKit Commit Bot 2015-07-10 17:41:42 PDT 
Comment on attachment 256570 [details]
Patch

Clearing flags on attachment: 256570

Committed r186700: <http://trac.webkit.org/changeset/186700>
Comment 5 WebKit Commit Bot 2015-07-10 17:41:47 PDT 
All reviewed patches have been landed.  Closing bug.