Bug 146826 – [CoordinatedGraphics] Override primaryLayerID in CoordinatedGraphicsLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

primaryLayerID is usefull to debug layer tree using showGraphicsLayerTree()

[Ryuan Choi]

Created attachment 256570 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 256570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256570&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124
> +    CoordinatedLayerID id() const { return m_id; }

primaryLayerID() just returns id(). So I'm not 100% sure if we should continue to keep id(). r+ed for now.

[Ryuan Choi]

(In reply to comment #2)
> Comment on attachment 256570 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256570&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:124
> > +    CoordinatedLayerID id() const { return m_id; }
> 
> primaryLayerID() just returns id(). So I'm not 100% sure if we should
> continue to keep id(). r+ed for now.

While PlatformLayerID is uint64_t, CoordinatedGraphicsLayer uses uint32_t as id and id is widely used including IPC message.

If refactoring does not have critical performance regression, we can remove id.
I will check it.

[WebKit Commit Bot]

Comment on attachment 256570 [details]
Patch

Clearing flags on attachment: 256570

Committed r186700: <http://trac.webkit.org/changeset/186700>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.