Bug 14682 - REGRESSION (24285-24399): alerts do not appear at W3C RTL test page
Summary: REGRESSION (24285-24399): alerts do not appear at W3C RTL test page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://www.w3.org/International/tests...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-07-19 21:42 PDT by Alexey Proskuryakov
Modified: 2007-07-22 22:43 PDT (History)
2 users (show)

See Also:


Attachments
reduction (93 bytes, text/html)
2007-07-22 13:23 PDT, Alexey Proskuryakov
no flags Details
patch (3.76 KB, patch)
2007-07-22 22:17 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-07-19 21:42:30 PDT
Steps to reproduce:
1) Open the bug URL
2) Click any of the "Click Me" buttons.

Resuls: an alert doesn't appear; there's an error in JS Console:

Object  (result of expression alert) does not allow calls.
http://www.w3.org/International/tests/test-rtl-chrome-1

Tested with nightly r24399.
Comment 1 David Kilzer (:ddkilzer) 2007-07-20 04:29:29 PDT
Works on Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.10 (8R218).

Comment 2 David Kilzer (:ddkilzer) 2007-07-20 04:30:54 PDT
<rdar://problem/5349746>
Comment 3 Alexey Proskuryakov 2007-07-22 13:23:12 PDT
Created attachment 15626 [details]
reduction
Comment 4 Alexey Proskuryakov 2007-07-22 13:40:19 PDT
Two commits that look somewhat suspicious are <http://trac.webkit.org/projects/webkit/changeset/24350> and <http://trac.webkit.org/projects/webkit/changeset/24287>.
Comment 5 mitz 2007-07-22 14:49:26 PDT
Probably r24350: fake getElementById properties now get priority over the autogenerated properties of the window prototype (see Window::getOwnPropertySlot)
Comment 6 Cameron Zwarich (cpst) 2007-07-22 19:22:20 PDT
(In reply to comment #4)
> Two commits that look somewhat suspicious are
> <http://trac.webkit.org/projects/webkit/changeset/24350> and
> <http://trac.webkit.org/projects/webkit/changeset/24287>.

I tried r24287 and the test passes, so it must be a later revision.
Comment 7 Sam Weinig 2007-07-22 22:17:50 PDT
Created attachment 15642 [details]
patch
Comment 8 Darin Adler 2007-07-22 22:22:36 PDT
Comment on attachment 15642 [details]
patch

r=me
Comment 9 Alexey Proskuryakov 2007-07-22 22:37:15 PDT
There's a mismatched closing tag here:

+    <div id="alert"></button>

Comment 10 Sam Weinig 2007-07-22 22:39:45 PDT
(In reply to comment #9)
> There's a mismatched closing tag here:
> 
> +    <div id="alert"></button>
> 

Eek, you're right.  I will fix it.
Comment 11 Sam Weinig 2007-07-22 22:43:36 PDT
Landed in r24528.