REGRESSION (24285-24399): alerts do not appear at W3C RTL test page

[Alexey Proskuryakov]

Steps to reproduce:
1) Open the bug URL
2) Click any of the "Click Me" buttons.

Resuls: an alert doesn't appear; there's an error in JS Console:

Object  (result of expression alert) does not allow calls.
http://www.w3.org/International/tests/test-rtl-chrome-1

Tested with nightly r24399.

[David Kilzer (:ddkilzer)]

Works on Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.10 (8R218).

[David Kilzer (:ddkilzer)]

<rdar://problem/5349746>

[Alexey Proskuryakov]

Created attachment 15626 [details]
reduction

[Alexey Proskuryakov]

Two commits that look somewhat suspicious are <http://trac.webkit.org/projects/webkit/changeset/24350> and <http://trac.webkit.org/projects/webkit/changeset/24287>.

Probably r24350: fake getElementById properties now get priority over the autogenerated properties of the window prototype (see Window::getOwnPropertySlot)

[Cameron Zwarich (cpst)]

(In reply to comment #4)
> Two commits that look somewhat suspicious are
> <http://trac.webkit.org/projects/webkit/changeset/24350> and
> <http://trac.webkit.org/projects/webkit/changeset/24287>.

I tried r24287 and the test passes, so it must be a later revision.

[Sam Weinig]

Created attachment 15642 [details]
patch

[Darin Adler]

Comment on attachment 15642 [details]
patch

r=me

[Alexey Proskuryakov]

There's a mismatched closing tag here:

+    <div id="alert"></button>

[Sam Weinig]

(In reply to comment #9)
> There's a mismatched closing tag here:
> 
> +    <div id="alert"></button>
> 

Eek, you're right.  I will fix it.

[Sam Weinig]

Landed in r24528.