SafariViewController loads partial webpage or entirely blank webpage
Created attachment 256531 [details] Patch
Attachment 256531 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:113: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:117: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:145: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:149: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 256531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256531&action=review r=mitz. > Source/WebKit2/UIProcess/ApplicationStateTracker.mm:136 > + break; ASSERT, instead
Committed r186648: <http://trac.webkit.org/changeset/186648>
Comment on attachment 256531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256531&action=review > Source/WebKit2/UIProcess/ApplicationStateTracker.mm:141 > + auto applicationStateMonitor = adoptNS([[BKSApplicationStateMonitor alloc] init]); Should this be m_applicationStateMonitor instead of "auto applicationStateMonitor" ? applicationStateMonitor seems unused, however you are using m_applicationStateMonitor below.
(In reply to comment #5) > Comment on attachment 256531 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256531&action=review > > > Source/WebKit2/UIProcess/ApplicationStateTracker.mm:141 > > + auto applicationStateMonitor = adoptNS([[BKSApplicationStateMonitor alloc] init]); > > Should this be m_applicationStateMonitor instead of "auto > applicationStateMonitor" ? applicationStateMonitor seems unused, however you > are using m_applicationStateMonitor below. Filed https://bugs.webkit.org/show_bug.cgi?id=160255.