Bug 146814 – It should be possible to run the OSR exit fuzzer

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Filip Pizlo]

Currently the jsc binary supports it, but there is no harness to wrap it.

[Filip Pizlo]

Created attachment 256537 [details]
the patch

[WebKit Commit Bot]

Attachment 256537 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Options.cpp:392:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/Options.cpp:397:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 256537 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256537&action=review

Looks good to me.

> Tools/Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:126
> +            $optionToUse = "--fireOSRExitFuzzAtOrAfter=1";

I think there could be a better name for this option. Will this always fire at and after the index passed in?
If so, maybe: "fireOSRExitFuzzStartingAt"

[Filip Pizlo]

(In reply to comment #3)
> Comment on attachment 256537 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256537&action=review
> 
> Looks good to me.
> 
> > Tools/Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:126
> > +            $optionToUse = "--fireOSRExitFuzzAtOrAfter=1";
> 
> I think there could be a better name for this option. Will this always fire
> at and after the index passed in?
> If so, maybe: "fireOSRExitFuzzStartingAt"

Fair point.  Maybe we can change that in another patch - I've already landed a lot of code that calls it fireOSRExitFuzzAtOrAfter.

[Mark Lam]

Comment on attachment 256537 [details]
the patch

r=me

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/186688