Need to fix this in order to conform to the format in which createObjectURL wants in DOMURLMediaStream
<rdar://problem/21754383>
Created attachment 256523 [details] Patch
Created attachment 256530 [details] Patch
Needed to create certain patches for tests that weren't updated
This looks fine, but I think eric should review to make sure webkitMediaStream -> MediaStream doesn't break something or do something bad to Media clients.
Sounds good, although shouldn't our tests account for that?
(In reply to comment #6) > Sounds good, although shouldn't our tests account for that? I assume the existing tests need to be updated for this change?
Comment on attachment 256530 [details] Patch Attachment 256530 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5143959122739200 New failing tests: js/dom/constructor-length.html js/dom/global-constructors-attributes.html
Created attachment 256534 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 256530 [details] Patch Attachment 256530 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5366369709195264 New failing tests: js/dom/constructor-length.html js/dom/global-constructors-attributes.html
Created attachment 256535 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 256545 [details] Patch
Comment on attachment 256545 [details] Patch Attachment 256545 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4589390797996032 New failing tests: js/dom/constructor-length.html
Created attachment 256548 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 256545 [details] Patch Attachment 256545 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5658399568035840 New failing tests: js/dom/constructor-length.html
Created attachment 256549 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 256555 [details] Patch
Comment on attachment 256555 [details] Patch Attachment 256555 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5992178656477184 New failing tests: js/dom/constructor-length.html
Created attachment 256557 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 256555 [details] Patch Attachment 256555 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5733973812576256 New failing tests: js/dom/constructor-length.html
Created attachment 256558 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 256582 [details] Patch
Comment on attachment 256582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review > Source/WebCore/Modules/mediastream/MediaStream.idl:32 > + InterfaceName=MediaStream, Just drop this line, this is already the interface name so it is now redundant.
Created attachment 256584 [details] Patch
Comment on attachment 256582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256582&action=review >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 >> + InterfaceName=MediaStream, > > Just drop this line, this is already the interface name so it is now redundant. Done!
(In reply to comment #25) > Comment on attachment 256582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256582&action=review > > >> Source/WebCore/Modules/mediastream/MediaStream.idl:32 > >> + InterfaceName=MediaStream, > > > > Just drop this line, this is already the interface name so it is now redundant. > > Done! Thanks.
Comment on attachment 256584 [details] Patch Clearing flags on attachment: 256584 Committed r186697: <http://trac.webkit.org/changeset/186697>
All reviewed patches have been landed. Closing bug.
This made js/dom/global-constructors-attributes.html fail on yosemite.