Bug 146799 - Web Inspector: Storage tab should have a scope bar in the sidebar
Summary: Web Inspector: Storage tab should have a scope bar in the sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-09 12:52 PDT by Timothy Hatcher
Modified: 2015-11-20 13:29 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2015-07-09 16:22 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Screenshot (181.89 KB, image/png)
2015-07-09 16:22 PDT, Timothy Hatcher 		no flags Details
Patch (8.82 KB, patch)
2015-07-09 16:29 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (9.17 KB, patch)
2015-07-09 16:59 PDT, Timothy Hatcher 		mark.lam: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-07-09 12:52:02 PDT 
Like the Resource tab, the Storage tab should have a scope bar at the top of the sidebar to make it fit in better.
Comment 1 Radar WebKit Bug Importer 2015-07-09 12:52:15 PDT 
<rdar://problem/21751880>
Comment 2 Timothy Hatcher 2015-07-09 16:22:08 PDT 
Created attachment 256538 [details]
Patch
Comment 3 Timothy Hatcher 2015-07-09 16:22:33 PDT 
Created attachment 256539 [details]
Screenshot
Comment 4 Timothy Hatcher 2015-07-09 16:29:41 PDT 
Created attachment 256540 [details]
Patch
Comment 5 Timothy Hatcher 2015-07-09 16:59:08 PDT 
Created attachment 256542 [details]
Patch
Comment 6 Mark Lam 2015-07-09 17:06:58 PDT 
Comment on attachment 256542 [details]
Patch

r=me
Comment 7 Timothy Hatcher 2015-07-09 17:13:19 PDT 
Comment on attachment 256542 [details]
Patch

r186654
Comment 8 Timothy Hatcher 2015-07-09 17:13:38 PDT 
http://trac.webkit.org/changeset/186654
Comment 9 Mark Lam 2015-07-09 17:27:20 PDT 
Comment on attachment 256542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256542&action=review

> Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49
> +            {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true},
> +            {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}];

Oops.  Just spotted these typos: "local-sotrage”, "session-sotrage"
Comment 10 Timothy Hatcher 2015-07-10 14:19:18 PDT 
(In reply to comment #9)
> Comment on attachment 256542 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256542&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:49
> > +            {identifier: "local-sotrage", title: WebInspector.UIString("Local Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: true},
> > +            {identifier: "session-sotrage", title: WebInspector.UIString("Session Storage"), classes: [WebInspector.DOMStorageTreeElement], localStorage: false}];
> 
> Oops.  Just spotted these typos: "local-sotrage”, "session-sotrage"

Fixed in a follow up.

https://trac.webkit.org/r186690