Bug 146790 - [Mac] Add some MediaStream files to Xcode project
Summary: [Mac] Add some MediaStream files to Xcode project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Daiter
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 146788
  Show dependency tree / graph
 
Reported: 2015-07-09 09:49 PDT by Matthew Daiter
Modified: 2015-08-05 11:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2015-07-22 09:38 PDT, Matthew Daiter 		no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2015-08-04 10:47 PDT, Matthew Daiter 		no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2015-08-04 11:32 PDT, Matthew Daiter 		no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2015-08-04 14:45 PDT, Matthew Daiter 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Daiter 2015-07-09 09:49:14 PDT 
Involves changing the WebCore.xcconfig files to make sure MediaStream Media Engine is being compiled
Comment 1 Radar WebKit Bug Importer 2015-07-09 09:50:22 PDT 
<rdar://problem/21747289>
Comment 2 Matthew Daiter 2015-07-22 09:38:51 PDT 
Created attachment 257278 [details]
Patch
Comment 3 Matthew Daiter 2015-08-04 10:47:54 PDT 
Created attachment 258183 [details]
Patch
Comment 4 Matthew Daiter 2015-08-04 11:08:09 PDT 
Comment on attachment 258183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258183&action=review

> Source/WebCore/platform/mediastream/MediaStreamPrivate.h:64
> +    MediaStreamPrivate() { }

Needed this in order to compile, minor detail about inheritance.
Comment 5 Matthew Daiter 2015-08-04 11:32:21 PDT 
Created attachment 258189 [details]
Patch
Comment 6 Matthew Daiter 2015-08-04 14:45:55 PDT 
Created attachment 258213 [details]
Patch
Comment 7 Eric Carlson 2015-08-04 14:54:45 PDT 
Comment on attachment 258213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258213&action=review

> Source/WebCore/ChangeLog:3
> +        Adding in MediaPrivateMediaStreamEngine to default compile

Please use the bug title.
Comment 8 WebKit Commit Bot 2015-08-05 11:40:22 PDT 
Comment on attachment 258213 [details]
Patch

Clearing flags on attachment: 258213

Committed r187971: <http://trac.webkit.org/changeset/187971>
Comment 9 WebKit Commit Bot 2015-08-05 11:40:25 PDT 
All reviewed patches have been landed.  Closing bug.