Bug 146776 – Web Inspector: Checkbox disappears when unchecking CSS background style

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Created attachment 256461 [details]
Test HTML Page

Safari's web inspector CSS editor removes the checkbox on certain styles when clicked.

* STEPS TO REPRODUCE
1. Open the attached HTML file (16214480.html)
2. Safari > Develop > Show Web Inspector > Inspect, click the div
3. Try unchecking each of the styles in the CSS editor, then rechecking them

* RESULTS
When you uncheck 'background', the checkbox you unchecked vanishes.
This makes it difficult to re-enable the style.
The problem does not occur with the other style ('color')

Expected: checkboxes shouldn't mysteriously disappear

* REGRESSION
Tested on 13D11, Safari 7.0.2

* NOTES
This problem does not occur in Google Chrome (tested on 33.0.1750.117), the checkboxes are always usable.

Semi-workaround for Safari is to position the cursor in the /* background: ... */, and delete the leading "/*". This re-enables the style, but you have to be sure to also remove the trailing "*/".

[Devin Rousso]

<rdar://problem/16214480>

[Devin Rousso]

Created attachment 256463 [details]
Patch

[Timothy Hatcher]

Comment on attachment 256463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256463&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:820
> +    _createCommentedCheckboxMarker(lineHandler)

Nit: lineHandle

[Devin Rousso]

Created attachment 256493 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256493 [details]
Patch

Clearing flags on attachment: 256493

Committed r186602: <http://trac.webkit.org/changeset/186602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.