Bug 146770 - [EFL] vibration/navigator-vibration.html failed after r186265
Summary: [EFL] vibration/navigator-vibration.html failed after r186265
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-08 19:45 PDT by Hunseop Jeong
Modified: 2015-07-08 22:54 PDT (History)
4 users (show)

See Also:


Attachments
Update layout test (2.24 KB, patch)
2015-07-08 20:53 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-07-08 19:45:26 PDT
Expected : 
PASS navigator.vibrate(0); is true
PASS navigator.vibrate([]); is true
PASS navigator.vibrate(1); is true
PASS navigator.vibrate([1, 2]); is true
PASS navigator.vibrate([1, 2, 3]); is true
PASS navigator.vibrate(); threw exception TypeError: Not enough arguments.
PASS navigator.vibrate([1], [2]); threw exception TypeError: Type error.
PASS successfullyParsed is true

Actual : 
PASS navigator.vibrate(0); is true
PASS navigator.vibrate([]); is true
PASS navigator.vibrate(1); is true
PASS navigator.vibrate([1, 2]); is true
PASS navigator.vibrate([1, 2, 3]); is true
PASS navigator.vibrate(); threw exception TypeError: Not enough arguments.
FAIL navigator.vibrate([1], [2]); should threw exception: Was true.
PASS successfullyParsed is true


navigator.vibrate([1], [2]); should threw typeError exception.
But it didn't threw the exception after r186265.
Comment 1 Daniel Bates 2015-07-08 20:30:35 PDT
The new behavior is correct. We need to update the test and expected result.
Comment 2 Daniel Bates 2015-07-08 20:53:08 PDT
Created attachment 256455 [details]
Update layout test
Comment 3 WebKit Commit Bot 2015-07-08 22:53:59 PDT
Comment on attachment 256455 [details]
Update layout test

Clearing flags on attachment: 256455

Committed r186582: <http://trac.webkit.org/changeset/186582>
Comment 4 WebKit Commit Bot 2015-07-08 22:54:03 PDT
All reviewed patches have been landed.  Closing bug.