Bug 146765 – [Cocoa] Report the first paint after committing a load as a rendering progress event

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

Allow clients to synchronize changes to their UI with the committed page painting for the first time (replacing the previous page) by reporting this as a rendering progress event.

Created attachment 256441 [details]
Add _WKRenderingProgressEventFirstPaint

[Tim Horton]

Comment on attachment 256441 [details]
Add _WKRenderingProgressEventFirstPaint

View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975
> +            _navigationState->didFirstPaint();

Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases?

Comment on attachment 256441 [details]
Add _WKRenderingProgressEventFirstPaint

View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975
>> +            _navigationState->didFirstPaint();
> 
> Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases?

I think so? It gets set to YES when the load is committed. Do you have a specific concern?

[Tim Horton]

Comment on attachment 256441 [details]
Add _WKRenderingProgressEventFirstPaint

View in context: https://bugs.webkit.org/attachment.cgi?id=256441&action=review

>>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:975
>>> +            _navigationState->didFirstPaint();
>> 
>> Will _needsResetViewStateAfterCommitLoadForMainFrame always be true in the necessary cases?
> 
> I think so? It gets set to YES when the load is committed. Do you have a specific concern?

Not at all, just couldn't check at the time and the name is not quite so definitive. Sounds good to me!

Committed <http://trac.webkit.org/r186586>.