Bug 146755 – Web Inspector: Add page weight and time back to the toolbar dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

http://trac.webkit.org/changeset/183328 removed the page weight and time. We have room, we should add these back.

[Radar WebKit Bug Importer]

<rdar://problem/21736228>

[Timothy Hatcher]

Created attachment 256427 [details]
Patch

[Timothy Hatcher]

Created attachment 256429 [details]
Screenshot

[Joseph Pecoraro]

Comment on attachment 256427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256427&action=review

r=me, but feel free to put up another patch for the missing bits if you want a second pair of eyes.

> Source/WebInspectorUI/UserInterface/Images/gtk/Time.svg:5
> +  <path style="block-progression:tb;text-indent:0;color:#000000;text-transform:none" d="m8.4866 0.01994c-4.1303 0-7.4866 3.3563-7.4866 7.4866s3.3563 7.4866 7.4866 7.4866 7.4866-3.3563 7.4866-7.4866-3.3563-7.4866-7.4866-7.4866zm0 1.9732c3.0494 0 5.5134 2.464 5.5134 5.5134s-2.464 5.5134-5.5134 5.5134-5.5134-2.464-5.5134-5.5134 2.464-5.5134 5.5134-5.5134z"/>

I believe the GTK folks did some optimization of their SVGs. They might appreciate some more reduction here, or a follow-up radar informing them they can improve these. The text-* attributes for instance don't do anything here.

> Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:149
> +            delete this._waitingForFirstMainResourceToStartTrackingSize;

Nit: Delete delete! This can nicely be "this._waitingForFirstMainResourceToStartTrackingSize = false"

> Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:190
> +        delete this._timeIntervalIdentifier;

Nit: Delete delete. This can safely be "this._timeIntervalIdentifier = undefined".

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:42
> +body.javascript .toolbar .dashboard-container {
> +    width: 25vw;
> +    min-width: 175px;
> +}

Would be worth testing this. We were 36 in a JSContext Inspector before this change, and that probably helps with showing the pause call frame when paused on breakpoints in a JSContext.

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:41
> +                handler: this._networkItemWasClicked

I don't see this handler. But it would be awesome if this opens/switches to the Network tab!

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:45
> +                handler: this._networkItemWasClicked

And maybe this one opens/switches to the Timelines tab!

[Timothy Hatcher]

Comment on attachment 256427 [details]
Patch

https://trac.webkit.org/r186580

[Andres Gomez Garcia]

Thanks you, guys, for taking into account the GTK+ port icons! :)