Bug 146742 - Media Session: indicate to clients whether a media session has active media elements
Summary: Media Session: indicate to clients whether a media session has active media e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-07-08 15:41 PDT by Matt Rajca
Modified: 2015-07-08 16:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.38 KB, patch)
2015-07-08 15:46 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2015-07-08 16:34 PDT, Matt Rajca 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-08 15:41:05 PDT 
Indicate to clients whether there are active media elements in a media session.
Comment 1 Radar WebKit Bug Importer 2015-07-08 15:42:11 PDT 
<rdar://problem/21734470>
Comment 2 Matt Rajca 2015-07-08 15:46:05 PDT 
Created attachment 256412 [details]
Patch
Comment 3 Tim Horton 2015-07-08 16:09:30 PDT 
Comment on attachment 256412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256412&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:2156
> +bool WKPageHasActiveMediaElements(WKPageRef page)

Seems pretty bizarre that something called this would return false if you have a <video> on the page (but have MEDIA_SESSION off)...
Comment 4 Matt Rajca 2015-07-08 16:13:28 PDT 
(In reply to comment #3)
> Comment on attachment 256412 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256412&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:2156
> > +bool WKPageHasActiveMediaElements(WKPageRef page)
> 
> Seems pretty bizarre that something called this would return false if you
> have a <video> on the page (but have MEDIA_SESSION off)...

I'll rename it to WKPageHasMediaSessionWithActiveMediaElements.
Comment 5 Matt Rajca 2015-07-08 16:34:55 PDT 
Created attachment 256421 [details]
Patch
Comment 6 Matt Rajca 2015-07-08 16:47:31 PDT 
Committed r186538: <http://trac.webkit.org/changeset/186538>