WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146737
Make ApplicationStateTracker be per view instead of being a singleton
https://bugs.webkit.org/show_bug.cgi?id=146737
Summary
Make ApplicationStateTracker be per view instead of being a singleton
Anders Carlsson
Reported
2015-07-08 12:41:51 PDT
Make ApplicationStateTracker be per view instead of being a singleton
Attachments
Patch
(11.60 KB, patch)
2015-07-08 12:43 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(12.19 KB, patch)
2015-07-08 12:58 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2015-07-08 12:43:56 PDT
Created
attachment 256398
[details]
Patch
WebKit Commit Bot
Comment 2
2015-07-08 12:46:56 PDT
Attachment 256398
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2015-07-08 12:58:11 PDT
Created
attachment 256401
[details]
Patch
WebKit Commit Bot
Comment 4
2015-07-08 12:59:59 PDT
Attachment 256401
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 5
2015-07-08 13:16:52 PDT
Comment on
attachment 256401
[details]
Patch rs=me
Anders Carlsson
Comment 6
2015-07-08 13:37:12 PDT
Committed
r186523
: <
http://trac.webkit.org/changeset/186523
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug