Bug 146737 - Make ApplicationStateTracker be per view instead of being a singleton
Summary: Make ApplicationStateTracker be per view instead of being a singleton
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-08 12:41 PDT by Anders Carlsson
Modified: 2015-07-08 13:37 PDT (History)
1 user (show)

See Also:


Attachments
Patch (11.60 KB, patch)
2015-07-08 12:43 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (12.19 KB, patch)
2015-07-08 12:58 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-07-08 12:41:51 PDT
Make ApplicationStateTracker be per view instead of being a singleton
Comment 1 Anders Carlsson 2015-07-08 12:43:56 PDT
Created attachment 256398 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-08 12:46:56 PDT
Attachment 256398 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-07-08 12:58:11 PDT
Created attachment 256401 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-08 12:59:59 PDT
Attachment 256401 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:126:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2015-07-08 13:16:52 PDT
Comment on attachment 256401 [details]
Patch

rs=me
Comment 6 Anders Carlsson 2015-07-08 13:37:12 PDT
Committed r186523: <http://trac.webkit.org/changeset/186523>