Bug 146733 – [Mac] Two clicks required to enable AirPlay at youtube.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Some videos at youtube.com don't switch to AirPlay the first time a route is chosen.

[Eric Carlson]

<rdar://problem/21556356>

[Eric Carlson]

Created attachment 256390 [details]
Proposed patch.

[Brent Fulgham]

Comment on attachment 256390 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=256390&action=review

r=me. I had a couple of questions about the m_targetChanged flag.

> Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203
>      // Do not take the target if another client has it and the client reporting a state change is not playing.

You should revise this comment to match the code below (or get rid of it?)

> Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283
> +            state->requestedPicker = false;

Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager exists for the life of the process, right? So does that mean future changes to target won't work right?

[Eric Carlson]

(In reply to comment #3)
> Comment on attachment 256390 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256390&action=review
> 
> r=me. I had a couple of questions about the m_targetChanged flag.
> 
> > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203
> >      // Do not take the target if another client has it and the client reporting a state change is not playing.
> 
> You should revise this comment to match the code below (or get rid of it?)
> 
Removed.

> > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283
> > +            state->requestedPicker = false;
> 
> Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager
> exists for the life of the process, right? So does that mean future changes
> to target won't work right?
>
Good point, fixed.

Thanks!

[Eric Carlson]

Committed r186519: https://trac.webkit.org/r186519