Bug 146730 - Do not waste window server memory for placeholder windows initiated by ThemeMac.
Summary: Do not waste window server memory for placeholder windows initiated by ThemeMac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-08 09:41 PDT by zalan
Modified: 2015-07-08 09:51 PDT (History)
0 users

See Also:

Attachments
Patch (2.69 KB, patch)
2015-07-08 09:46 PDT, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-07-08 09:41:21 PDT 
Use defer:YES when initiating WebCoreThemeWindow
Comment 1 zalan 2015-07-08 09:41:56 PDT 
rdar://problem/20321222
Comment 2 zalan 2015-07-08 09:46:18 PDT 
Created attachment 256382 [details]
Patch
Comment 3 zalan 2015-07-08 09:49:32 PDT 
Committed r186509: <http://trac.webkit.org/changeset/186509>
Comment 4 Simon Fraser (smfr) 2015-07-08 09:51:32 PDT 
Comment on attachment 256382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256382&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:78
> +    // going to draw into it. The other arguments match what you get when calling -[NSWindow init].

I don't think you need the "The other arguments" bit.