Bug 146717 - [GTK] Deactivate GObject bindings for static methods
Summary: [GTK] Deactivate GObject bindings for static methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-08 02:29 PDT by Xabier Rodríguez Calvar
Modified: 2015-07-08 03:35 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.85 KB, patch)
2015-07-08 02:33 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2015-07-08 02:29:03 PDT
[GTK] Deactivate GObject bindings for static methods
Comment 1 Xabier Rodríguez Calvar 2015-07-08 02:33:42 PDT
Created attachment 256366 [details]
Patch

Deactivate GObject bindings generation for static methods
Comment 2 Xabier Rodríguez Calvar 2015-07-08 02:51:58 PDT
Carlos suggested me to remove the static methods from the GObject bindings generation. I don't know if it might be interesting for the ObjC ones too. That's why I added you.
Comment 3 Xabier Rodríguez Calvar 2015-07-08 02:53:48 PDT
(In reply to comment #2)
> Carlos suggested me to remove the static methods from the GObject bindings
> generation. I don't know if it might be interesting for the ObjC ones too.
> That's why I added you.

The idea is that the implemenetation might be wrong since in the case of both GObject and ObjC the generation creates something with IMPL-> which doesn't sound right for static methods.
Comment 4 WebKit Commit Bot 2015-07-08 03:35:46 PDT
Comment on attachment 256366 [details]
Patch

Clearing flags on attachment: 256366

Committed r186496: <http://trac.webkit.org/changeset/186496>
Comment 5 WebKit Commit Bot 2015-07-08 03:35:49 PDT
All reviewed patches have been landed.  Closing bug.