Bug 146708 - Web Inspector: Improve names for unprefixed animation events
Summary: Web Inspector: Improve names for unprefixed animation events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-07-07 20:41 PDT by Joseph Pecoraro
Modified: 2015-07-07 22:24 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.47 KB, patch)
2015-07-07 20:41 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-07 20:41:22 PDT
* SUMMARY
Improve names for unprefixed animation events.

* TEST
<style>
div {
    width: 100px;
    height: 100px;
    background-color: red;
    animation-name: example;
    animation-duration: 4s;
}

@keyframes example {
    from {background-color: red;}
    to {background-color: yellow;}
}
</style>

<div id="x"></div>

<script>
var box = document.getElementById('x');
box.addEventListener("animationend", function(e) {
    console.log("animationend", e);
});
</script>

* STEPS TO REPRODUCE
1. Record timeline of Test until animation end event
  => "Animationend Event Dispatched" should be "Animation End Event Dispatched"
Comment 1 Joseph Pecoraro 2015-07-07 20:41:59 PDT
Created attachment 256352 [details]
[PATCH] Proposed Fix
Comment 2 Simon Fraser (smfr) 2015-07-07 21:51:54 PDT
Comment on attachment 256352 [details]
[PATCH] Proposed Fix

Should it distinguish between "webkitAnimationEnd" and "animationend" in the UI?
Comment 3 WebKit Commit Bot 2015-07-07 22:24:50 PDT
Comment on attachment 256352 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 256352

Committed r186488: <http://trac.webkit.org/changeset/186488>
Comment 4 WebKit Commit Bot 2015-07-07 22:24:55 PDT
All reviewed patches have been landed.  Closing bug.