Bug 146702 – Add actions to image previews

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Add actions to image previews

<rdar://problem/21642654>

[Beth Dakin]

Created attachment 256332 [details]
Patch

[WebKit Commit Bot]

Attachment 256332 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WKImagePreviewViewController.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Created attachment 256337 [details]
Patch

[WebKit Commit Bot]

Attachment 256337 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:309:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yongjun Zhang]

Comment on attachment 256337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256337&action=review

> Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> +    _WKActivatedElementInfo *_activatedElementInfo;

I think we should retain the _activeElementInfo.

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> +    NSURL *targetURL = [NSURL URLWithString:positionInformation.url];

Nit: Could we use _web_URLWithWTFString: here?

The patch looks good to me, I will let a WebKit reviewer to comment.

[Beth Dakin]

(In reply to comment #5)
> Comment on attachment 256337 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256337&action=review
> 
> > Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> > +    _WKActivatedElementInfo *_activatedElementInfo;
> 
> I think we should retain the _activeElementInfo.
> 

Will do.

> > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> > +    NSURL *targetURL = [NSURL URLWithString:positionInformation.url];
> 
> Nit: Could we use _web_URLWithWTFString: here?
> 

Yes!

> The patch looks good to me, I will let a WebKit reviewer to comment.

[Beth Dakin]

Thanks all! http://trac.webkit.org/changeset/186515