Bug 146691 - Web Inspector: Details sidebar doesn't activate on first selected resource in Network tab
Summary: Web Inspector: Details sidebar doesn't activate on first selected resource in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-07 12:57 PDT by Jon Davis
Modified: 2015-07-08 16:55 PDT (History)
8 users (show)

See Also:


Attachments
Shows disabled sidebar icon, and reluctance of sidebar to open. (1.15 MB, video/mp4)
2015-07-07 14:03 PDT, Jon Davis
no flags Details
Patch (6.55 KB, patch)
2015-07-08 14:46 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2015-07-07 12:57:39 PDT
The sidebar icon remains in a disabled state in the Network tab even after selecting a resource. The second selection of a resource activates the sidebar icon. Additionally, after reloading, clicking the sidebar icon before selecting a resource does nothing. Then when you select a resource, the sidebar opens with the resource.

If the sidebar icon is disabled, it shouldn't toggle anything to open. However, I think it should always be clickable and if no resource selection exists, the main document should auto-select and open the sidebar.
Comment 1 Radar WebKit Bug Importer 2015-07-07 12:57:55 PDT
<rdar://problem/21709833>
Comment 2 Timothy Hatcher 2015-07-07 13:15:36 PDT
I wonder if there is an exception that is causing this. Can you inspect the inspector to check? http://trac.webkit.org/wiki/WebInspectorDebugging
Comment 3 Jon Davis 2015-07-07 14:03:48 PDT
Created attachment 256321 [details]
Shows disabled sidebar icon, and reluctance of sidebar to open.

I could not get the second behavior to repro in this video. Clicking the sidebar icon with no resource selected, then selecting the resource does not open the sidebar as it did when I was first noticing the behavior.
Comment 4 Timothy Hatcher 2015-07-08 14:46:34 PDT
Created attachment 256406 [details]
Patch
Comment 5 Joseph Pecoraro 2015-07-08 16:22:41 PDT
Comment on attachment 256406 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2015-07-08 16:55:23 PDT
Comment on attachment 256406 [details]
Patch

Clearing flags on attachment: 256406

Committed r186540: <http://trac.webkit.org/changeset/186540>
Comment 7 WebKit Commit Bot 2015-07-08 16:55:26 PDT
All reviewed patches have been landed.  Closing bug.