Windows does not yet have a memory pressure handler implementation.
Created attachment 256309 [details] Patch
Comment on attachment 256309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256309&action=review > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:85 > + // Only install a memory check timer for Win32, since Win64 has much more memory to play with. This is not necessarily true. 64-bit windows can be installed on systems with 1GB of memory, for example. I don't think the memory pressure handler should be 32-bit only. > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:88 > + memCheckTimer()->startRepeating(60.0); This just checks the memory every minute, right?
(In reply to comment #2) > Thanks for reviewing :) > > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:85 > > + // Only install a memory check timer for Win32, since Win64 has much more memory to play with. > > This is not necessarily true. 64-bit windows can be installed on systems > with 1GB of memory, for example. I don't think the memory pressure handler > should be 32-bit only. > I agree, I will update the patch. > > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:88 > > + memCheckTimer()->startRepeating(60.0); > > This just checks the memory every minute, right? Yes.
Created attachment 256404 [details] Patch
Comment on attachment 256404 [details] Patch Very nice! r=me.
(In reply to comment #5) > Comment on attachment 256404 [details] > Patch > > Very nice! r=me. Thanks!
Comment on attachment 256404 [details] Patch Clearing flags on attachment: 256404 Committed r186607: <http://trac.webkit.org/changeset/186607>
All reviewed patches have been landed. Closing bug.