Bug 146683 – [GTK] pango should be included in the default jhbuild moduleset

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild moduleset or else remove fontconfig (which would make it hard to keep tests working -> we should add pango).

[Michael Catanzaro]

Created attachment 256397 [details]
Patch

[Michael Catanzaro]

EWS doesn't provide anywhere near enough output to diagnose the problem, due to bug #145697

[Michael Catanzaro]

Oh, pango is just too old.

[Carlos Alberto Lopez Perez]

FYI: Debian 8 jessie (that is the distro of the bots and EWS machines) has pango=1.36.8

[Michael Catanzaro]

Created attachment 256449 [details]
Patch

[Martin Robinson]

(In reply to comment #5)
> Created attachment 256449 [details]
> Patch

Did you mean to mark this patch for review?

[Michael Catanzaro]

No, it's broken and it's hard to see why; let's wait for bug #145697.

[Carlos Alberto Lopez Perez]

I tried to manually build it on ltilve-gtk-ews and it built just fine.  But I started from a clean build, so maybe is the incremental build the one that breaks?

[Michael Catanzaro]

Comment on attachment 256449 [details]
Patch

OK, Carlos Lopez and I both manually did clean builds on ltilve's EWS and they succeeded, so let's proceed with this.

[WebKit Commit Bot]

Comment on attachment 256449 [details]
Patch

Clearing flags on attachment: 256449

Committed r186655: <http://trac.webkit.org/changeset/186655>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.