Bug 146683 - [GTK] pango should be included in the default jhbuild moduleset
Summary: [GTK] pango should be included in the default jhbuild moduleset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 145696
  Show dependency treegraph
 
Reported: 2015-07-07 09:59 PDT by Michael Catanzaro
Modified: 2015-07-09 17:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2015-07-08 12:33 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2015-07-08 19:01 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-07-07 09:59:34 PDT
Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild moduleset or else remove fontconfig (which would make it hard to keep tests working -> we should add pango).
Comment 1 Michael Catanzaro 2015-07-08 12:33:07 PDT
Created attachment 256397 [details]
Patch
Comment 2 Michael Catanzaro 2015-07-08 13:56:10 PDT
EWS doesn't provide anywhere near enough output to diagnose the problem, due to bug #145697
Comment 3 Michael Catanzaro 2015-07-08 14:21:13 PDT
Oh, pango is just too old.
Comment 4 Carlos Alberto Lopez Perez 2015-07-08 14:58:15 PDT
FYI: Debian 8 jessie (that is the distro of the bots and EWS machines) has pango=1.36.8
Comment 5 Michael Catanzaro 2015-07-08 19:01:57 PDT
Created attachment 256449 [details]
Patch
Comment 6 Martin Robinson 2015-07-09 10:57:28 PDT
(In reply to comment #5)
> Created attachment 256449 [details]
> Patch

Did you mean to mark this patch for review?
Comment 7 Michael Catanzaro 2015-07-09 11:50:57 PDT
No, it's broken and it's hard to see why; let's wait for bug #145697.
Comment 8 Carlos Alberto Lopez Perez 2015-07-09 11:58:49 PDT
I tried to manually build it on ltilve-gtk-ews and it built just fine.  But I started from a clean build, so maybe is the incremental build the one that breaks?
Comment 9 Michael Catanzaro 2015-07-09 15:04:01 PDT
Comment on attachment 256449 [details]
Patch

OK, Carlos Lopez and I both manually did clean builds on ltilve's EWS and they succeeded, so let's proceed with this.
Comment 10 WebKit Commit Bot 2015-07-09 17:21:37 PDT
Comment on attachment 256449 [details]
Patch

Clearing flags on attachment: 256449

Committed r186655: <http://trac.webkit.org/changeset/186655>
Comment 11 WebKit Commit Bot 2015-07-09 17:21:40 PDT
All reviewed patches have been landed.  Closing bug.