Bug 146681 - Bring back the GNU ar check to create thin archives on non-Linux systems
Summary: Bring back the GNU ar check to create thin archives on non-Linux systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-07 06:30 PDT by Ting-Wei Lan
Modified: 2015-07-17 23:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2015-07-07 06:33 PDT, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2015-07-16 00:56 PDT, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2015-07-07 06:30:56 PDT 
We used 'ar -V' to check whether we are using GNU ar and add the T (thin archive) flag if GNU ar is used when we still had autotools build. It was added in https://bugs.webkit.org/show_bug.cgi?id=128596. However, autotools build was removed, and we use '${CMAKE_SYSTEM_NAME} STREQUAL "Linux"' to do the GNU ar check instead in cmake build, which means all non-Linux systems cannot use GNU ar thin archive feature.

This means getting debug build of WebKit on *BSD or other non-Linux systems can be hard because WebCore static archive can be larger than 4 GiB and cause error: https://bugs.webkit.org/show_bug.cgi?id=140384. GNU ar thin archive feature is really needed to prevent the error.

After applying the attached patch and modifying some environment variables, I can get a debug build of WebKitGTK+ on FreeBSD now.
Comment 1 Ting-Wei Lan 2015-07-07 06:33:11 PDT 
Created attachment 256296 [details]
Patch
Comment 2 Ting-Wei Lan 2015-07-16 00:56:08 PDT 
Created attachment 256895 [details]
Patch
Comment 3 WebKit Commit Bot 2015-07-17 23:33:58 PDT 
Comment on attachment 256895 [details]
Patch

Clearing flags on attachment: 256895

Committed r186987: <http://trac.webkit.org/changeset/186987>
Comment 4 WebKit Commit Bot 2015-07-17 23:34:03 PDT 
All reviewed patches have been landed.  Closing bug.