Bug 146678 - [GTK] Fix rsvg build due to missing libcroco dependency
Summary: [GTK] Fix rsvg build due to missing libcroco dependency
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 145696
  Show dependency tree / graph
 
Reported: 2015-07-07 01:27 PDT by Emanuele Aina
Modified: 2015-07-08 12:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2015-07-07 01:31 PDT, Emanuele Aina 		mrobinson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Aina 2015-07-07 01:27:07 PDT 
The jhbuild moduleset currently fails due to librsvg needing libcroco.
Comment 1 Emanuele Aina 2015-07-07 01:31:10 PDT 
Created attachment 256291 [details]
Patch
Comment 2 Martin Robinson 2015-07-07 10:10:16 PDT 
Comment on attachment 256291 [details]
Patch

We currently reserve the JHBuild for dependencies that actually affect test results. Other dependencies should be added to Tools/gtk/install-dependencies.
Comment 3 Emanuele Aina 2015-07-08 01:14:43 PDT 
Oh, got it, and libcroco is already listed there. Sorry for the noise, thanks!
Comment 4 Michael Catanzaro 2015-07-08 07:54:05 PDT 
Let me repurpose this bug slightly. I want install-dependencies to be used only for software that does not depend on anything we build in jhbuild. libcroco should be built by jhbuild because it depends on glib.
Comment 5 Martin Robinson 2015-07-08 08:03:26 PDT 
I think there is definitely a value in keeping the JHBuild moduleset as small as possible. WebKit developers shouldn't have to build the entire world.
Comment 6 Michael Catanzaro 2015-07-08 08:07:23 PDT 
Let's discuss in bug #145696.
Comment 7 Michael Catanzaro 2015-07-08 12:51:05 PDT 
We agreed to only add these dependencies to jhbuild as problems arise, at least for now. Hopefully there are few issues in practice.