Bug 146675 - REGRESSION (r185629): Web Inspector: Filtering doesn't display any items if folders are used to organize the web page resources
Summary: REGRESSION (r185629): Web Inspector: Filtering doesn't display any items if f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2015-07-06 23:44 PDT by Tobias Reiss
Modified: 2015-07-08 12:28 PDT (History)
8 users (show)

See Also:


Attachments
Video that shows bug where Resources are not filtered (2.58 MB, video/quicktime)
2015-07-06 23:44 PDT, Tobias Reiss
no flags Details
Patch (4.00 KB, patch)
2015-07-08 08:20 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Reiss 2015-07-06 23:44:50 PDT
Created attachment 256281 [details]
Video that shows bug where Resources are not filtered

- go to sz.de
- click on Resources Tab ("All Resources" must be pre-selected)
- click on "Documents" and select "StyleSheets" from Dropdown menu

IS: "No filter results"
EXPECTED: show filter results

This bug is not related to a specific Website, but it's harder to reproduce for Websites that had been already opened before.   
It seems the Resources are not "available/initialized" yet, as the Filter action appears.
Comment 1 Radar WebKit Bug Importer 2015-07-06 23:45:08 PDT
<rdar://problem/21699260>
Comment 2 Timothy Hatcher 2015-07-07 11:07:43 PDT
<rdar://problem/21643002>
Comment 3 Timothy Hatcher 2015-07-07 13:43:25 PDT
Text filtering in filters is broken too.

This regressed because:

http://trac.webkit.org/changeset/185629/trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

Which regressed because of:

http://trac.webkit.org/changeset/171645/trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

I plan to revert r185629. I'll then consider a better for r171645.
Comment 4 Timothy Hatcher 2015-07-08 08:20:58 PDT
Created attachment 256375 [details]
Patch
Comment 5 Joseph Pecoraro 2015-07-08 11:38:27 PDT
Comment on attachment 256375 [details]
Patch

r=me, this is pretty complex now with all these booleans =(
Comment 6 WebKit Commit Bot 2015-07-08 12:28:51 PDT
Comment on attachment 256375 [details]
Patch

Clearing flags on attachment: 256375

Committed r186520: <http://trac.webkit.org/changeset/186520>
Comment 7 WebKit Commit Bot 2015-07-08 12:28:55 PDT
All reviewed patches have been landed.  Closing bug.