Bug 146674 – AX: VoiceOver cannot get to any content in Yahoo Mail messages table

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

VoiceOver cannot get to any content in Yahoo Mail messages table

WebKit is exposing some presentational elements as AXGroup. These are in between the AXTable and AXRows.

<rdar://problem/21405928>

[chris fleizach]

Created attachment 256280 [details]
patch

[WebKit Commit Bot]

Attachment 256280 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:27:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 256282 [details]
patch

[WebKit Commit Bot]

Comment on attachment 256282 [details]
patch

Clearing flags on attachment: 256282

Committed r186587: <http://trac.webkit.org/changeset/186587>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brent Fulgham]

This created two new test failures on Windows. Can you take a look?

[chris fleizach]

(In reply to comment #6)
> This created two new test failures on Windows. Can you take a look?

I see the test that was part of this patch is failing


 test 	results	image results	actual failure	expected failure	history
+accessibility/aria-table-with-presentational-elements.html	expected actual diff pretty diff	

that's because the DRT methods are not implemented on windows, so we should skip that test (i'll do that now)

what's the other failing test?

[Brent Fulgham]

(In reply to comment #7)
> (In reply to comment #6)
> > This created two new test failures on Windows. Can you take a look?
> 
> I see the test that was part of this patch is failing
> 
> 
>  test 	results	image results	actual failure	expected failure	history
> +accessibility/aria-table-with-presentational-elements.html	expected actual
> diff pretty diff	
> 
> that's because the DRT methods are not implemented on windows, so we should
> skip that test (i'll do that now)
> 
> what's the other failing test?

Sorry -- the other test failure is not related to you. Please just skip the test.

Thanks!

[chris fleizach]

(In reply to comment #7)
> (In reply to comment #6)
> > This created two new test failures on Windows. Can you take a look?
> 
> I see the test that was part of this patch is failing
> 
> 
>  test 	results	image results	actual failure	expected failure	history
> +accessibility/aria-table-with-presentational-elements.html	expected actual
> diff pretty diff	
> 
> that's because the DRT methods are not implemented on windows, so we should
> skip that test (i'll do that now)
> 
> what's the other failing test?

http://trac.webkit.org/changeset/186595