Created attachment 256273 [details] Actual * STEPS TO REPRODUCE 1. Add the following CSS to any rule in the sidebar: width: -webkit-calc(1px); 2. After clicking outside of that rule (to remove focus), the CSS will be reformatted as: width: -webkit- calc(1px);a
<rdar://problem/21698881>
Created attachment 256274 [details] Patch
Comment on attachment 256274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256274&action=review r-, we should add a test for this. Source/WebInspectorUI/Tools/PrettyPrinting/css-rule-tests Why don't I see it happen on this when I load the test case? Source/WebInspectorUI/Tools/PrettyPrinting/index.html?mode=css-rule&content=width%3A%20-webkit-calc(1px)%3B > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Views/CodeMirrorFormatters.js: Now only adds a space if both the current and previous tokens are a property, value, > + or atom. Gross formatting! Wrap a little earlier so this is more comfortable to read.
Created attachment 256287 [details] Video of Current Functionality This is what is currently happening on my release build.
Created attachment 256289 [details] Patch
Created attachment 256316 [details] Patch
Comment on attachment 256316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256316&action=review r=me, thanks for addressing all my comments! > Source/WebInspectorUI/Tools/PrettyPrinting/index.html:54 > + // Here, the "calc" keyword is added to allow the do-not-add-whitespace-before-prefixed-property-value Nit: Double space. Also don't call out a particular test by name, that is the kind of comment that can go stale in the future if that test gets removed or renamed. Just mention its to behave more like the frontend.
Created attachment 256317 [details] Patch
Comment on attachment 256317 [details] Patch Clearing flags on attachment: 256317 Committed r186477: <http://trac.webkit.org/changeset/186477>
All reviewed patches have been landed. Closing bug.