Bug 146653 – Revert use of SVG <mask> elements for -webkit-mask-image (r176798, r177494, r186180)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Need to revert these changes, because of the number of regressions: bug 141857, bug 146509, bug 146561.

[Simon Fraser (smfr)]

rdar://problem/21435233

[Simon Fraser (smfr)]

Created attachment 256262 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 256263 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 256266 [details]
Patch

[Simon Fraser (smfr)]

Patches are interdependent, so patches 2 and 3 won't apply.

[Dean Jackson]

Comment on attachment 256262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256262&action=review

> Source/WebCore/platform/graphics/MaskImageOperation.cpp:222
> -
> +    

:(

[Dean Jackson]

Comment on attachment 256263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256263&action=review

> Source/WebCore/css/CSSValue.h:174
>          SVGColorClass,
>          SVGPaintClass,
> -        WebKitCSSResourceClass,
>  

Not sure this one is needed, but it doesn't matter.

> Source/WebCore/css/CSSValue.h:192
>  #endif
> +        WebKitCSSResourceClass
>  

See above.

[Dean Jackson]

Comment on attachment 256266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256266&action=review

> Source/WebCore/css/CSSValue.h:-192
> -        WebKitCSSResourceClass
> -

Oh, you got rid of it here.

[Simon Fraser (smfr)]

https://trac.webkit.org/r186390
https://trac.webkit.org/r186391
https://trac.webkit.org/r186392

[Chris Dumez]

This caused http/tests/misc/mask-image-accept.html to start failing:
https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r186390%20(52826)/results.html

[Chris Dumez]

(In reply to comment #10)
> This caused http/tests/misc/mask-image-accept.html to start failing:
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r186390%20(52826)/results.html

Looks like only the Windows bot is having trouble with this though. The test in question is using -webkit-mask-image but not SVG.

[Chris Dumez]

(In reply to comment #11)
> (In reply to comment #10)
> > This caused http/tests/misc/mask-image-accept.html to start failing:
> > https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> > r186390%20(52826)/results.html
> 
> Looks like only the Windows bot is having trouble with this though. The test
> in question is using -webkit-mask-image but not SVG.

Ah, never mind, the issue was that the bot had processed r186390 but not r186391 and r186392 yet. The test is now passing again on the Windows bot.